Skip to content

fix: offer add_braces on assignments #20844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2025
Merged

fix: offer add_braces on assignments #20844

merged 1 commit into from
Oct 24, 2025

Conversation

@A4-Tacks
Copy link
Member 

fn foo() {
    let x =$0 n + 100;
}
fn foo() {
    let x = {
        n + 100
    };
}

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 15, 2025
Veykril
Veykril approved these changes Oct 23, 2025
View reviewed changes
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@A4-Tacks
Add applicable on assignment for add_braces
8d72c3d 
```rust
fn foo() {
    let x =$0 n + 100;
}
```
->
```rust
fn foo() {
    let x = {
        n + 100
    };
}
```
@A4-Tacks A4-Tacks force-pushed the add-braces-assignment branch from 658a5b4 to 8d72c3d Compare October 23, 2025 19:59
@A4-Tacks A4-Tacks requested a review from Veykril October 24, 2025 01:03
@A4-Tacks
Copy link
Member Author

Okay, I rebased it to resolve the conflict of merging

@ShoyuVanilla ShoyuVanilla added this pull request to the merge queue Oct 24, 2025
Merged via the queue into rust-lang:master with commit 72af6f5 Oct 24, 2025
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 24, 2025
@A4-Tacks A4-Tacks deleted the add-braces-assignment branch October 24, 2025 02:07
A4-Tacks added a commit to A4-Tacks/rust-analyzer that referenced this pull request Oct 24, 2025
@A4-Tacks
minor: Update ide-assist docs for add_braces
06eae7d 
Partial of rust-lang#20844
@A4-Tacks A4-Tacks mentioned this pull request Oct 24, 2025
Merged
@lnicola lnicola changed the title Add applicable on assignment for add_braces fix: offer add_braces on assignments Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Veykril Veykril Awaiting requested review from Veykril

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@A4-Tacks @Veykril @ShoyuVanilla @rustbot